Closed
Bug 727131
Opened 12 years ago
Closed 12 years ago
Pref needed to allow "Search Google for" tabs to open in background
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 13
People
(Reporter: tracy.cooperjr, Assigned: Gavin)
References
Details
Attachments
(1 file)
2.32 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:13.0a1) Gecko/20120214 Firefox/13.0a1 Build ID: 20120214031227 Steps to reproduce: Searched using context menu option "Search Google for". Actual results: Tab opened in Foreground. Expected results: Should have opened in background per "browser.tabs.loadInBackground" setting but due to Bug 695482 it no longer does.
Updated•12 years ago
|
Blocks: 695482
Status: UNCONFIRMED → NEW
Component: Untriaged → Menus
Ever confirmed: true
QA Contact: untriaged → menus
Comment 1•12 years ago
|
||
A new pref in about:config to override the changes in bug 695482 is required.
Updated•12 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
Updated•12 years ago
|
Assignee | ||
Comment 2•12 years ago
|
||
"is required" is a little strong. "is humbly requested" perhaps? :) I want to be clear that the reason I'm going to fix this is: - our previous behavior was long-standing, and some people have gotten used to it - adding a pref is trivial, and introduces very little maintenance overhead I don't want this to be perceived as a precedent that implies we'll be adding prefs to every new behavior change, because we aren't going to do that.
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Thanks Gavin. My statement 'is required' was meant to mean a new pref would be needed, rather than hooking the behavior of "browser.tabs.loadInBackground". Fully understood about it 'not becoming a norm' for changes.
Status: ASSIGNED → NEW
OS: All → Windows 7
Hardware: All → x86
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
Comment 5•12 years ago
|
||
Comment on attachment 597265 [details] [diff] [review] patch >+pref("browser.search.context.inBackground", false); *.loadInBackground for consistency with similar prefs
Attachment #597265 -
Flags: review?(dao) → review+
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dbf20cd5526f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
You need to log in
before you can comment on or make changes to this bug.
Description
•