kumar rishav (:rishav_) Reporter
	Description • 9 years ago

STR:
1.Go to compose.
2.Add recepient (whose name is long i.e length>40)
3.Now tap on the recepient.
4.check in Confirm window: recepient name over flow.

	Julien Wajsberg [:julienw]
	Comment 3 • 9 years ago

I think it's better do put this change in the Building Blocks.

	Julien Wajsberg [:julienw]
	Comment 4 • 9 years ago

Bug 1105857 is in v2.2 and v2.0m, I think we should fix in both branches.

	ashutosh.nath.agarwal Assignee
	Comment 5 • 9 years ago

Hi. I'm a new contributor. I will fix it in the shared css (building blocks).
What should I do to fix in both batches - v2.2 and v2.0

	ashutosh.nath.agarwal Assignee
	Comment 6 • 9 years ago

Hi. I have fixed the bug in building blocks. Kindly guide me for the other branch. Thanks

	Julien Wajsberg [:julienw]
	Comment 7 • 9 years ago

(In reply to ashutosh.nath.agarwal from comment #6)
> Hi. I have fixed the bug in building blocks. Kindly guide me for the other
> branch. Thanks

I think it will be made automatically from your patch to master.

	Oleg Zasypkin [:azasypkin]
	Comment 8 • 9 years ago

Comment on attachment 8554185 [details] [review]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master

Per GitHub looks like Julien is already reviewing/reviewed this patch, redirecting to him :) 

Ashutosh, please don't forget to ask for review from Pavel Ivanov (:ivanovpavel) as well as it's BB change that will affect a big chunk of applications.

	Oleg Zasypkin [:azasypkin]
	Comment 9 • 9 years ago

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Bug 1105857 is in v2.2 and v2.0m, I think we should fix in both branches.

As far as I remember v2.2 and v2.0m patches have a bunch of differences especially related to styling. So having said that I can't repro this issue on v2.0m - name is automatically broken into several lines there.

	Pavel Ivanov [:ivanovpavel][:pivanov] UX
	Comment 10 • 9 years ago

Comment on attachment 8554185 [details] [review]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master

LGTM r+ and thanks :)

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 11 • 9 years ago

triage: non-blocking but nice to have it fixed. please ask for approval to uplift.

	Julien Wajsberg [:julienw]
	Comment 12 • 9 years ago

Comment on attachment 8554185 [details] [review]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master

r=me

	Julien Wajsberg [:julienw]
	Comment 13 • 9 years ago

I restarted the failing tests just to be sure they're intermittent. Please don't add checkin-needed until they finish.

	GitHub Autolander Bot
	Comment 14 • 9 years ago

https://github.com/mozilla-b2g/gaia/pull/27652

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

	Julien Wajsberg [:julienw]
	Comment 15 • 9 years ago

master: 229efc18377cd203be97d92995175c08e06307ad

	GitHub Autolander Bot
	Comment 16 • 9 years ago

https://github.com/mozilla-b2g/gaia/pull/27652

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

	ashutosh.nath.agarwal Assignee
	Comment 17 • 9 years ago

Thank you :)

	Julien Wajsberg [:julienw]
	Comment 19 • 9 years ago

Comment on attachment 8554185 [details] [review]
[PullReq] ash7594:Bug1125525 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Don't know
[User impact] if declined: See attachment 8587820 [details]
[Testing completed]: yes, it's in master since January.
[Risk to taking this patch] (and alternatives if risky): very low, one-line CSS change that does not change layout.
[String changes made]: none

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 20 • 9 years ago

triage: the triage meeting decided to fix.

	Julien Wajsberg [:julienw]
	Comment 21 • 9 years ago

Dear triagers, look at comment 11 :)
(does it mean we have a broken process?)

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 22 • 9 years ago

No, sorry for not making it clear.
We re-triaged this because this is a duplicate to bug 150793 being nominated.
The decision made today is based on below reasons:
1. it's a regression which has impact on the usability. 
2. there's already a fix
3. risk is very low
4. we need blocking status to uplift

	Ryan VanderMeulen [:RyanVM]
	Comment 23 • 9 years ago

Please nominate this patch for Gaia v2.2 approval when you get a chance.

	Julien Wajsberg [:julienw]
	Comment 24 • 9 years ago

Already done.

	Ryan VanderMeulen [:RyanVM]
	Comment 25 • 9 years ago

v2.2: https://github.com/mozilla-b2g/gaia/commit/8bd31d871d107c61102e991a772bbcc7383c5395

	Jayme Mercado [:JMercado] (Inactive 3/4/2016)
	Comment 26 • 9 years ago

This issue is verified fixed on the latest 3.0 and 2.2 Nightly Flame builds.

Actual Results: Overly long contact names are wrapped and do not go off screen

Environmental Variables:
Device: Flame 3.0 KK (319 MB) (Full Flash)
BuildID: 20150604010200
Gaia: 9e10483c5808f94f4a0a9f6afe30aae2c5b42b4c
Gecko: 98820360ab66
Gonk: 040bb1e9ac8a5b6dd756fdd696aa37a8868b5c67
Version: 41.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Environmental Variables:
Device: Flame 2.2 KK (319 MB) (Full Flash)
BuildID: 20150604002503
Gaia: b96e657ce2822df5da5da1a8ba91c38ad3281bc9
Gecko: 273f8ee45c88
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0